Skip to content

editable inline card titles - #592

Merged
juliusknorr merged 5 commits into
masterfrom
251-card-title-inline
Aug 24, 2018
Merged

editable inline card titles#592
juliusknorr merged 5 commits into
masterfrom
251-card-title-inline

Conversation

@NebriBlackwing

@NebriBlackwingNebriBlackwing commented Aug 21, 2018

Copy link
Copy Markdown
Member

Signed-off-by: Ryan Fletcher ryan.fletcher@codepassion.ca

  • Resolves: #
  • Target version: master

Summary

closes issue: #251

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@codecov

codecovBot commented Aug 21, 2018

Copy link
Copy Markdown

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #592 +/- ##
=======================================
Coverage 75.46% 75.46% =======================================
Files 52 52 Lines 1969 1969 =======================================
Hits 1486 1486 Misses 483 483

Comment threadtemplates/part.board.mainView.php Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the input-inline class here, this should make the input look like the other inline editing fields. Also we need some adjustment so that the height and text of the card is not flipping around when changing from view to edit mode.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the class, struggling with controlling the height and text. Not sure where the extra height is coming from. Any advice on how to track it down? css issues like this is usually a struggle for me.

@NebriBlackwing

NebriBlackwing commented Aug 23, 2018

Copy link
Copy Markdown
MemberAuthor

@nextcloud/deck "Also we need some adjustment so that the height and text of the card is not flipping around when changing from view to edit mode." - juliushaertl

Any css guru's out there able to help me out here with the height / width jumps when the control switches from a span to input element? see line 79 on templates/part.board.mainView.php it is driving me bonkers.

@NebriBlackwing

Copy link
Copy Markdown
MemberAuthor

AHA! @juliushaertl take a look at my last commit, let me know if that is satisfactory for the "jumps".

Comment threadjs/controller/BoardController.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace issues again ;)

Comment threadjs/controller/BoardController.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace

Comment threadtemplates/part.board.mainView.php Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

@juliusknorr

Copy link
Copy Markdown
Member

@Nebri I've pushed a commit to fix the padding issue for the input field. Good to be merged, once the whitespace issues are fixed. 👍

@NebriBlackwing

Copy link
Copy Markdown
MemberAuthor

@juliushaertl I found the user settings in visual studio code to automatically trim whitespaces from the end of a line. This should murder the whitespace issue for me. Requested changes are in.

Ryan Fletcherand others added 5 commits August 24, 2018 14:56
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
@juliusknorr
juliusknorr merged commit 939f5fa into masterAug 24, 2018
@juliusknorr
juliusknorr deleted the 251-card-title-inline branch August 24, 2018 13:57
@juliusknorrjuliusknorr mentioned this pull request Oct 8, 2018
33 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NebriBlackwing@juliusknorr