Skip to content

Don't allow empty card titles - #611

Merged
juliusknorr merged 3 commits into
masterfrom
bug/589/empty-titles
Oct 9, 2018
Merged

Don't allow empty card titles#611
juliusknorr merged 3 commits into
masterfrom
bug/589/empty-titles

Conversation

@weeman1337

Copy link
Copy Markdown
Member

Summary

  • stores the titles temporarily when editing
    • if the new title is empty it restores the previous one
    • if the new title is not empty it commits the changes
  • enables the browser form validations to work on "enter"

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • [-] Tests (unit, integration, api and/or acceptance) are included
  • [-] Documentation (manuals or wiki) has been updated or is not required

@weeman1337weeman1337 added this to the 0.4.2 milestone Sep 6, 2018
@codecov

codecovBot commented Sep 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #611 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #611 +/- ##
=======================================
Coverage 76.07% 76.07% =======================================
Files 57 57 Lines 2474 2474 =======================================
Hits 1882 1882 Misses 592 592

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks @weeman1337

@juliusknorrjuliusknorr modified the milestones: 0.4.2, 0.5.0Oct 9, 2018
@juliusknorrjuliusknorr changed the title Bug/589/empty titlesDon't allow empty card titlesOct 9, 2018
@juliusknorrjuliusknorr mentioned this pull request Oct 9, 2018
33 tasks
@juliusknorr
juliusknorr merged commit 014e7e4 into masterOct 9, 2018
@juliusknorr
juliusknorr deleted the bug/589/empty-titles branch October 9, 2018 10:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@weeman1337@juliusknorr