Uh oh!
There was an error while loading. Please reload this page.
[nc16-only] Implementing fulltextsearch - #885
Merged
Merged
Conversation
ArtificialOwl
commented
Feb 11, 2019
MemberAuthor
|
Closed
juliusknorr
commented
Feb 14, 2019
Member
Thanks a lot @daita Looks good in general, will need to setup the fulltestsearch app to do some testing. Could you look into the test failures? |
ArtificialOwlforce-pushed
the
feature/noid/nc16-fulltextsearch
branch
from
February 20, 2019 11:52
089e02c to
aa1d953Comparejuliusknorr
commented
Mar 19, 2019
Member
@daita Any chance you can have a look at the failing tests? 😉 |
juliusknorr
commented
Mar 27, 2019
Member
@daita Any news? I plan to push out a first beta at the end of the week, so it would be good to have this in there. |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> cleaning Signed-off-by: Maxence Lange <maxence@artificial-owl.com> cleaning some useless code Signed-off-by: Maxence Lange <maxence@artificial-owl.com> compat nc6 Signed-off-by: Maxence Lange <maxence@artificial-owl.com> compat nc16 Signed-off-by: Maxence Lange <maxence@artificial-owl.com> Merge remote-tracking branch 'origin/feature/noid/nc16-fulltextsearch' into feature/noid/nc16-fulltextsearch Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
juliusknorrforce-pushed
the
feature/noid/nc16-fulltextsearch
branch
from
March 28, 2019 17:51
8e1b46d to
bc33a71CompareMember
|
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
approved these changes
Mar 29, 2019
juliusknorr
commented
Mar 29, 2019
Member
3ebe794 needs to be reverted after nextcloud/server#14905 has been merged |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the app fail on NC13/14, this needs to be on a specific version for NC16 (but should also works for NC15)
It does not catch the search from the searchbar within the deck app, but allow to search from the fulltextsearch app.
ToDo