Fix memory limit config issue (close #1413)

[dashohoxha]

Replace single quotes by double quotes on Dockerfiles.

[J0WI]

This would basically revert #1379. The single quotes are intentional to read the variable on runtime.

[dashohoxha]

This would basically revert #1379. The single quotes are intentional to read the variable on runtime.

That commit does not do what it claims on the subject/description, because you cannot read ENV variables on runtime when PHP runs as www-data.
It is creating problems to everyone (#1413) for a long time.

[J0WI]

I just double checked this with a simple phpinfo() script and it shows me the correct values from the environment variables.

[dashohoxha]

Would you describe how you did the test, so that we can repeat it? Or we just have to take your word for it?

[J0WI]

Sure. I run docker run --rm -e PHP_MEMORY_LIMIT=1024M -e PHP_UPLOAD_LIMIT=2048M --name nextcloud-env-test -p 8080:80 nextcloud, docker exec nextcloud-env-test sh -c 'echo "<?php phpinfo();" > index.php' and verified the results at http://localhost:8080/.

[dashohoxha]

You are right, it works. Thanks for sharing the instructions.

In the default docker image apache2 is called with exec apache2 ...:
https://github.com/docker-library/php/blob/master/8.0/bullseye/apache/apache2-foreground#L40
So it inherits the environment of root and this is why it can access the variables PHP_MEMORY_LIMIT and PHP_UPLOAD_LIMIT.

However, in my case, I am extending the standard image by installing systemd, so apache2 is called by systemd and in this case it cannot read the variables PHP_MEMORY_LIMIT and PHP_UPLOAD_LIMIT, which are defined in the root's environment.
My workaround is to modify /usr/local/etc/php/conf.d/nextcloud.ini directly with the correct values.

[dashohoxha]

I am closing this pull request.