Uh oh!
There was an error while loading. Please reload this page.
Set default value for trusted proxies - #891
Closed
kesselb wants to merge 2 commits into
Closed
Conversation
kesselbforce-pushed
the
feature/trusted_proxies
branch
from
October 8, 2019 13:23
3aca15a to
cd77d84CompareSigned-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
feature/trusted_proxies
branch
from
October 8, 2019 13:31
cd77d84 to
0ea2b55Comparekesselb
commented
Oct 8, 2019
ContributorAuthor
Hmm. I see we use a different way for trusted domains. Adding the trusted proxies once on setup to config.php would save some getenv calls. Let me know which way do you prefer. |
kesselb
commented
Oct 13, 2019
ContributorAuthor
As discussed at #819 (comment) its bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some reports at nextcloud/server about broken url generation. This change should improve the situation for docker users.
Nginx and Traefik forward X-Forwarded-Host and X-Forwarded-Proto by default. Url generation should work out of the box with the ip of the reverse proxy listed in trusted_proxies.