Skip to content

Document some phpdoc return type changes in OCP in 27 - #10513

Merged
nickvergessen merged 1 commit into
masterfrom
fix/document-return-type-fixes-in-ocp-27
May 31, 2023
Merged

Document some phpdoc return type changes in OCP in 27#10513
nickvergessen merged 1 commit into
masterfrom
fix/document-return-type-fixes-in-ocp-27

Conversation

@come-nc

@come-nccome-nc commented May 30, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

@come-nccome-nc added this to the Nextcloud 27 milestone May 30, 2023
@come-nccome-nc self-assigned this May 30, 2023
@come-nc

come-nc commented May 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Not sure I put this in the right place actually, what does Client API means? Should I add a Changed API section to backend changes instead?

@nickvergessen

nickvergessen commented May 30, 2023

Copy link
Copy Markdown
Member

Not sure I put this in the right place actually, what does Client API means?

Should be in Back-end changes not Client API (OCS end points)

Should I add a Changed API section to backend changes instead?

Yes

@come-nc

come-nc commented May 30, 2023

Copy link
Copy Markdown
ContributorAuthor

Screenshot_20230530_143504

@come-nc

come-nc commented May 30, 2023

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

nickvergessen
nickvergessen reviewed May 30, 2023
View reviewed changes
Comment threaddeveloper_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.rst Outdated
@come-nc
Document some phpdoc return type changes in OCP in 27
d35cf3c
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/document-return-type-fixes-in-ocp-27 branch from afc44aa to d35cf3cCompareMay 30, 2023 14:26
@nickvergessen
nickvergessen merged commit b0610b7 into masterMay 31, 2023
@nickvergessen
nickvergessen deleted the fix/document-return-type-fixes-in-ocp-27 branch May 31, 2023 09:10
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request May 31, 2023
Merged
@nickvergessennickvergessen mentioned this pull request May 31, 2023
Merged
@blizzz

blizzz commented May 31, 2023

Copy link
Copy Markdown
Member

master is 28

@blizzzblizzz modified the milestones: Nextcloud 27, Nextcloud 28May 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@blizzzblizzzAwaiting requested review from blizzz

Assignees

@come-nccome-nc

Labels

3. to review

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc@nickvergessen@blizzz