Skip to content

fix(admin): Remove "latest" archive reference during upgrades - #11838

Merged
joshtrichards merged 2 commits into
masterfrom
jtr/admin-manual-upgrade-not-latest
May 23, 2024
Merged

fix(admin): Remove "latest" archive reference during upgrades#11838
joshtrichards merged 2 commits into
masterfrom
jtr/admin-manual-upgrade-not-latest

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented May 17, 2024

Copy link
Copy Markdown
Member

☑️ Resolves

  • adjusts step 2 to avoid breaking things
    • specifically: installing the latest tarball/zip file isn't always the correct choice; e.g. 27 -> 29 will break their installation
  • also adds reminder about checking new system requirements and the standard upgrade requirements

🖼️ Screenshots

image

@joshtrichards
fix(admin): Remove "latest" archive reference to avoid accidents
e6b19af
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards

joshtrichards commented May 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable29

@joshtrichards

joshtrichards commented May 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable28

@joshtrichards

joshtrichards commented May 17, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@joshtrichardsjoshtrichards changed the title fix(admin): Remove "latest" archive reference to avoid accidentsfix(admin): Remove "latest" archive reference during upgradesMay 22, 2024
tflidd
tflidd approved these changes May 23, 2024
View reviewed changes

@tfliddtflidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the improvements.
Only thing, I don't know if it is perhaps to obvious, that the www-data user is mainly for debian-based distributions. Most beginners use that, and other systems with different users might have enough experience to be aware of this. But could be a further improvement (other parts of the documentation are affected by this as well).

Comment threadadmin_manual/maintenance/manual_upgrade.rst Outdated
@joshtrichards

joshtrichards commented May 23, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Only thing, I don't know if it is perhaps to obvious, that the www-data user is mainly for debian-based distributions.

Yeah I agree. It gets confusing. That's going to take further passes later on (outside of this PR). The docs are littered with stuff like that. The big picture overview on tackling that is #11447. In the mean time... 🤷‍♂️

@joshtrichards
fix(install): copy->move data directory during manual upgrades
41ff00b
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards
joshtrichards merged commit 5f0a7ba into masterMay 23, 2024
@joshtrichards
joshtrichards deleted the jtr/admin-manual-upgrade-not-latest branch May 23, 2024 13:39
This was referenced May 23, 2024
Merged
Merged
Merged
@joshtrichards

joshtrichards commented May 23, 2024

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbotbackportbotBot mentioned this pull request May 23, 2024
Merged
@github-actions

This comment was marked as resolved.

Sign in to view
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfliddtfliddtflidd approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to reviewbugfeedback-requestedmanual: admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshtrichards@tflidd