Skip to content

NCU unstable namespace - #12329

Merged
ArtificialOwl merged 1 commit into
masterfrom
feat/48891/nct-namespace
Nov 7, 2024
Merged

NCU unstable namespace#12329
ArtificialOwl merged 1 commit into
masterfrom
feat/48891/nct-namespace

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Oct 28, 2024•
edited by skjnldsv
Loading

Copy link
Copy Markdown
Member

@ArtificialOwlArtificialOwl mentioned this pull request Oct 28, 2024
Merged
provokateurin
provokateurin requested changes Oct 28, 2024
View reviewed changes
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
provokateurin
provokateurin reviewed Oct 30, 2024
View reviewed changes
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
@nickvergessen

nickvergessen commented Nov 6, 2024

Copy link
Copy Markdown
Member
  • OCP code must never mention NCT. It can not require it as an argument, constant or return something from NCT.
  • NCT will be added to the nextcloud-deps/OCP package for easier testing with psalm

@ArtificialOwl
ArtificialOwlforce-pushed the feat/48891/nct-namespace branch from 44ea69c to b5e9d6cCompareNovember 6, 2024 10:16
@ArtificialOwl

ArtificialOwl commented Nov 6, 2024

Copy link
Copy Markdown
MemberAuthor

  • OCP code must never mention NCT. It can not require it as an argument, constant or return something from NCT.

    • NCT will be added to the nextcloud-deps/OCP package for easier testing with psalm

added to documentation

susnux
susnux reviewed Nov 6, 2024
View reviewed changes
Comment threaddeveloper_manual/digging_deeper/api.rst Outdated
<https://nextcloud-server.netlify.app/>`_ for further details.


PHP testing API

@susnuxsusnuxNov 6, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like this is about API for testing not API that is in testing state.
Maybe "Unstable PHP API"? As "unstable" is a more common term for this kind of API in general?

(At least for me "testing" is more like we provide our \Test namespace)

@nickvergessennickvergessenNov 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering similarly, also for the lib/testing/ folder in Server. Other options could be Experimental or Preview (colliding with previews/thumbnails)

@ArtificialOwlArtificialOwlNov 7, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree on those points, but from previous vocal discussions:

  • testing is above unstable (at least from debian's point of view)
  • 'Experimental' would means NCE to be the name of the namespace, which is an already used acronym,
  • 'Preview' would also conflict,
  • 'devel' can be confusing too, as it can be interpreted as API for development ...

unstable might the only valid term that does not conflict that much and also reflect the 'unstable'/'prone to changes'

@ArtificialOwlArtificialOwlNov 7, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, after discussion with @provokateurin, testing have been renamed to unstable.

Files location: /lib/unstable/
namespace: NCU\

@ArtificialOwl
ArtificialOwlforce-pushed the feat/48891/nct-namespace branch from ec1b2e3 to 21dcbe6CompareNovember 7, 2024 18:58
@ArtificialOwlArtificialOwl changed the title NCT testing namespaceNCU unstable namespaceNov 7, 2024
@ArtificialOwl
NCU unstable namespace
7f1ed36
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the feat/48891/nct-namespace branch from 21dcbe6 to 7f1ed36CompareNovember 7, 2024 20:23
@ArtificialOwl

ArtificialOwl commented Nov 7, 2024

Copy link
Copy Markdown
MemberAuthor

squashed, screenshot updated, merged.

@ArtificialOwl
ArtificialOwl merged commit 633d170 into masterNov 7, 2024
@ArtificialOwl
ArtificialOwl deleted the feat/48891/nct-namespace branch November 7, 2024 20:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@susnuxsusnuxsusnux left review comments
@provokateurinprovokateurinprovokateurin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtificialOwl@nickvergessen@susnux@provokateurin