Uh oh!
There was an error while loading. Please reload this page.
Removed X-Frame-Options: SAMEORIGIN header - #1707
Closed
dvdgsng wants to merge 1 commit into
Closed
Conversation
Some headers don't need to be set in nginx anymore, since they are hardcoded into Nextcloud. This causes problems with the header `X-Frame-Options: SAMEORIGIN`, which should not be set twice. See: * https://docs.nextcloud.com/server/17/admin_manual/installation/harden_server.html#serve-security-related-headers-by-the-web-server * https://docs.nextcloud.com/server/12/admin_manual/release_notes.html#updates-to-nginx-configuration * nextcloud/server#4764 * https://blog.qualys.com/securitylabs/2015/10/20/clickjacking-a-common-implementation-mistake-that-can-put-your-websites-in-danger
skjnldsv
commented
Nov 20, 2019
Member
Please see #1703 |
skjnldsv
requested review from
kesselb
and removed request for
J0WI and MichaIngNovember 20, 2019 15:13
dvdgsng
commented
Nov 20, 2019
Author
missed that, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some headers don't need to be set in nginx anymore, since they are hardcoded into Nextcloud. This causes problems with the header
X-Frame-Options: SAMEORIGIN, which should not be set twice.See: