Uh oh!
There was an error while loading. Please reload this page.
Update deprecated globals in 18 - #1949
Merged
Merged
Conversation
Ref nextcloud/server#17402 Ref nextcloud/server#17392 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Apr 10, 2020
MemberAuthor
/backport to stable18 |
skjnldsv
approved these changes
Apr 10, 2020
korelstar
commented
Apr 10, 2020
Member
This should be added to https://github.com/nextcloud/eslint-plugin/blob/master/lib/rules/no-deprecations.js , too. |
ChristophWurst
commented
Apr 10, 2020
MemberAuthor
Will do today :) |
The backport to stable18 failed. Please do this backport manually. |
ChristophWurst
commented
Apr 10, 2020
MemberAuthor
The file is not in stable18 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#17402
Ref nextcloud/server#17392