Skip to content

Do not (yet) recommended PHP 7.4 - #2117

Closed
J0WI wants to merge 1 commit into
nextcloud:stable18from
J0WI:18-7.4-not-recommended
Closed

Do not (yet) recommended PHP 7.4#2117
J0WI wants to merge 1 commit into
nextcloud:stable18from
J0WI:18-7.4-not-recommended

Conversation

@J0WI

@J0WIJ0WI commented May 30, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@J0WI
Do not (yet) recommended PHP 7.4
77873f5
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WIJ0WI mentioned this pull request May 30, 2020
Closed
@rullzer

rullzer commented Jun 5, 2020

Copy link
Copy Markdown
Member

Why not?

@ChristophWurst

ChristophWurst commented Jun 5, 2020

Copy link
Copy Markdown
Member

#2037 (comment) but I do not think this is necessarily true anymore.

@kesselb

kesselb commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

There are some warnings with 7.4.

@rullzer

rullzer commented Jun 5, 2020

Copy link
Copy Markdown
Member

Warnings are not really a reason not to recommend something.
We should just fix them. I am running nextcloud for some months now with php7.4 and it is working just fine.

@kesselb

kesselb commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

I am running nextcloud for some months now with php7.4 and it is working just fine.

You are a developer. That's a different story ;) Admin checks the logs, see warnings, searches for a reason. It's often hard to judge for them if the log message is critical or not.

nextcloud/groupfolders#907
nextcloud/server#18996

@ChristophWurst

ChristophWurst commented Jun 5, 2020

Copy link
Copy Markdown
Member

But you fixed those, right?

@kesselb

kesselb commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

But you fixed those, right?

The patch with SCSS is not backported yet. As the original patch is for scssphp 1.03 and we still have scssphp 0.7.x with stable18 not sure if it will.

@rullzer

rullzer commented Jun 5, 2020

Copy link
Copy Markdown
Member

ok then lets do it for stable18.

@J0WI

J0WI commented Feb 25, 2021

Copy link
Copy Markdown
ContributorAuthor

18 is EOL

@J0WIJ0WI closed this Feb 25, 2021
@J0WI
J0WI deleted the 18-7.4-not-recommended branch February 25, 2021 13:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewmanual: admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@J0WI@rullzer@ChristophWurst@kesselb