Uh oh!
There was an error while loading. Please reload this page.
Content list documentation - #638
Merged
Merged
Conversation
skjnldsv
requested review from
BernhardPosselt, ChristophWurst, MorrisJobke, jancborchardt and juliusknorrDecember 21, 2017 14:12
jancborchardt
commented
Dec 21, 2017
Member
Nice! :) Should we specifically say something about that we recommend using the cc @nextcloud/designers |
skjnldsv
commented
Dec 21, 2017
MemberAuthor
@jancborchardt yes, it's a requirement :) |
juliusknorr
commented
Jan 3, 2018
Member
Looks good to me. Just the screenshot besides the first code snippet should be moved above, because it currently shrinks the code block so that it is quite hard to read. |
MemberAuthor
@juliushaertl I'll remove the inline image code block EDIT: done, please review |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
juliusknorr
approved these changes
Jan 3, 2018
jancborchardt
commented
Jan 4, 2018
Member
Aaawesome! :) Great job with the docs as always @skjnldsv |
skjnldsv
commented
Jan 5, 2018
MemberAuthor
Thank Jan! 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After nextcloud/server#7195
Please review!
Is it clear enough? :)