Skip to content

Fix language selector entries - #78

Merged
MorrisJobke merged 1 commit into
masterfrom
fix_lang_selector
Feb 8, 2018
Merged

Fix language selector entries#78
MorrisJobke merged 1 commit into
masterfrom
fix_lang_selector

Conversation

@rullzer

@rullzerrullzer commented Feb 7, 2018

Copy link
Copy Markdown
Member

Related to nextcloud/server#8218

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Fix language selector entries
559fb0b
Related to nextcloud/server#8218
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 14 milestone Feb 7, 2018
@nickvergessen

nickvergessen commented Feb 7, 2018

Copy link
Copy Markdown
Member

is this 14 only, or needs backporting to 13?

MorrisJobke
MorrisJobke requested changes Feb 8, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎 we should make it compatible to stable12, 13 and master and this I would go for another else branch in case the string starts with an underscore. Or does that make no sense, because we backport the same translations to all stable branches anyway?

@rullzerrullzer mentioned this pull request Feb 8, 2018
Merged
1 task
@nickvergessen

nickvergessen commented Feb 8, 2018

Copy link
Copy Markdown
Member

👎 we should make it compatible to stable12, 13 and master and this I would go for another else branch in case the string starts with an underscore. Or does that make no sense, because we backport the same translations to all stable branches anyway?

Not sure what you are refering to. This app has stableX branches and seperate releases for each supported version anyway?

@MorrisJobke

MorrisJobke commented Feb 8, 2018

Copy link
Copy Markdown
Member

Not sure what you are refering to. This app has stableX branches and seperate releases for each supported version anyway?

🙈 Okay - let's do it 👍

@MorrisJobke
MorrisJobke merged commit eeb38fa into masterFeb 8, 2018
@MorrisJobke
MorrisJobke deleted the fix_lang_selector branch February 8, 2018 10:01
@WastelWastel mentioned this pull request Apr 10, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to reviewenhancement

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@nickvergessen@MorrisJobke