Uh oh!
There was an error while loading. Please reload this page.
Init all answers from props - #1383
Merged
Merged
Conversation
Chartman123
approved these changes
Oct 16, 2022
hamza221
approved these changes
Oct 18, 2022
Before this only the text answers were initialized with the `values` property. This now initializes also `Dropdown` and `Date` from the `values` property, which is required for loading a saved state of a form. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnuxforce-pushed
the
feat/init-answers-from-props
branch
from
October 25, 2022 11:53
908605c to
e40f8c1CompareChartman123
commented
Oct 25, 2022
Collaborator
Member
Nah, sorry, @Chartman123 it was not meant that hard... I'm not sure, if this is good or if we should more have a look in a common way between the questions but that I would need to check properly. This is why I didn't react here. But I'm also not the almighty blocker, if I do not react. ;) |
Chartman123
commented
Oct 25, 2022
Collaborator
Yes, that's what I understood, so perhaps I didn't find the right words here 😇 |
susnux
commented
Oct 26, 2022
CollaboratorAuthor
No problem take your time to review! |
hamza221
commented
Dec 8, 2022
Contributor
Any updates on merging this PR? |
jotoeri
commented
Dec 17, 2022
Member
Finally found some time. Sorry for that. Seems to be ok currently. 🙈 |
jotoeri
approved these changes
Dec 17, 2022
jotoeri
commented
Dec 17, 2022
Member
Argh. Now i was too fast. Rebase would have been good. 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this only the text answers were initialized with the
valuesproperty.This now also initializes
DropdownandDatefrom thevaluesproperty, which is required for loading a saved state of a form like in #1382