Skip to content

Add title on public page - #315

Merged
skjnldsv merged 1 commit into
masterfrom
fix/public-header-title
May 5, 2020
Merged

Add title on public page#315
skjnldsv merged 1 commit into
masterfrom
fix/public-header-title

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 29, 2020

Copy link
Copy Markdown
Member

FInal fix#4

Capture d’écran_2020-04-29_19-06-46

@skjnldsvskjnldsv added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Apr 29, 2020
@skjnldsvskjnldsv self-assigned this Apr 29, 2020
@skjnldsvskjnldsv mentioned this pull request Apr 29, 2020
Closed
@jancborchardt

jancborchardt commented Apr 29, 2020

Copy link
Copy Markdown
Member

FInal fix #4

Capture d’écran_2020-04-29_19-06-46

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"
That’s better than repeating the title of the form which already is shown in very large.

@skjnldsv

skjnldsv commented Apr 30, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"

Not anymore, we removed it for privacy reasons apparently
EDIT: only when specified on your displayname visibility settings

@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 30, 2020
@skjnldsv

skjnldsv commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

Blocked by nextcloud/server#20744

@jancborchardt

jancborchardt commented Apr 30, 2020

Copy link
Copy Markdown
Member

In the subline we usually show the "shared-by" info as per the class name, for additional context: "shared by username"

Not anymore, we removed it for privacy reasons apparently
EDIT: only when specified on your displayname visibility settings

Blocker is merged, can you adjust the subline then to show the "shared by username" info? If it’s disabled in the displayname visibility settings, just don’t show any subline.

@jancborchardt
jancborchardtforce-pushed the fix/public-header-title branch from ca566cd to fa85dd6CompareApril 30, 2020 22:17
@jancborchardtjancborchardt added this to the 2.0 milestone May 1, 2020
@skjnldsv
skjnldsvforce-pushed the fix/public-header-title branch from fa85dd6 to ab1503bCompareMay 4, 2020 15:26
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 4, 2020
@skjnldsv

skjnldsv commented May 4, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased, ready to go @jancborchardt@jotoeri :)

image

@skjnldsv
skjnldsvforce-pushed the fix/public-header-title branch from ab1503b to 8359300CompareMay 4, 2020 15:44
@codecov-io

codecov-io commented May 4, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #315 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #315 +/- ##
========================================
Coverage 0.00% 0.00% - Complexity 173 181 +8 
========================================
Files 18 18 Lines 965 1001 +36 ========================================
- Misses 965 1001 +36
Impacted FilesCoverage ΔComplexity Δ
lib/AppInfo/Application.php0.00% <ø> (ø)1.00 <0.00> (ø)
lib/Controller/ApiController.php0.00% <0.00%> (ø)63.00 <11.00> (+2.00)
lib/Controller/PageController.php0.00% <0.00%> (ø)16.00 <0.00> (-8.00)
lib/Controller/SystemController.php0.00% <ø> (ø)8.00 <0.00> (ø)
lib/Db/FormMapper.php0.00% <ø> (ø)5.00 <0.00> (ø)
lib/Db/OptionMapper.php0.00% <ø> (ø)4.00 <0.00> (ø)
lib/Db/SubmissionMapper.php0.00% <ø> (ø)5.00 <0.00> (ø)
lib/Service/FormsService.php0.00% <0.00%> (ø)22.00 <14.00> (+14.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b53cb...5b9f65f. Read the comment docs.

jotoeri
jotoeri reviewed May 4, 2020
View reviewed changes
Comment threadlib/Controller/PageController.php
jotoeri
jotoeri reviewed May 4, 2020
View reviewed changes
Comment threadlib/Controller/PageController.php Outdated
@jotoeri
jotoeri self-requested a review May 4, 2020 18:40
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 5, 2020
@skjnldsv
Add title on public page
5b9f65f
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the fix/public-header-title branch from 9cfc113 to 5b9f65fCompareMay 5, 2020 06:55
@skjnldsv
skjnldsv merged commit 86de8c0 into masterMay 5, 2020
@skjnldsv
skjnldsv deleted the fix/public-header-title branch May 5, 2020 06:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotoerijotoerijotoeri approved these changes
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugSomething isn't workingdesignRelated to the design

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Don't show Nextcloud Toolbar with all apps

4 participants

@skjnldsv@jancborchardt@codecov-io@jotoeri