create "file app" public share links if the slideshow is opened from …

[icewind1991]

Fixes#268

We also need to look at the public share links that are shown in the slideshow from the gallery app, currently if you use those links it will always download the image with no method of viewing it in browser.

[MorrisJobke]

• ✅ open files app, open slideshow from there -> link fine
• ❌ open gallery app, open slideshow from there -> link broken - now http://192.168.99.100/server/apps/gallery/s/lmfsNZgRWFx7CU1

[icewind1991]

@MorrisJobke this is only meant to fix the link from the files app

We also need to look at the public share links that are shown in the slideshow from the gallery app, currently if you use those links it will always download the image with no method of viewing it in browser.

[codecov]

Codecov Report

Merging #271 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #271 +/- ##
============================================
- Coverage 82.39% 81.93% -0.47% 
Complexity 334 334 ============================================
Files 38 38 Lines 1284 1284 ============================================
- Hits 1058 1052 -6 - Misses 226 232 +6

Impacted Files	Coverage Δ	Complexity Δ
lib/Middleware/SharingCheckMiddleware.php	85% <0%> (-15%)	7% <0%> (ø)
lib/Middleware/EnvCheckMiddleware.php	89.39% <0%> (-4.55%)	24% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7b1d2...c08177b. Read the comment docs.

[MorrisJobke]

I rebased this to incorporate #303 of @rullzer

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

Do we maybe want to only create the normal share links and completely drop the special gallery share links, because they automatically download?

[icewind1991]

For single image links we should create the normal links, for folder links the gallery ones are fine

[MorrisJobke]

For single image links we should create the normal links, for folder links the gallery ones are fine

Correct.

[MorrisJobke]

@oparoz Nextcloud 13 or 14? Would be interesting for the release of the RC2 today ;)

[oparoz]

Let's merge and get some testing :)

[MorrisJobke]

@oparoz Could you backport this to stable13?

[oparoz]

Maybe tonight, but if not, it will have to wait for the weekend.

[MorrisJobke]

@oparoz What about the back port?

[skjnldsv]

backport #407