Skip to content

Update app to fit 18 new Sharing sidebar - #153

Merged
skjnldsv merged 3 commits into
masterfrom
comply-to-new-sidebar-and-use-axios
Nov 28, 2019
Merged

Update app to fit 18 new Sharing sidebar#153
skjnldsv merged 3 commits into
masterfrom
comply-to-new-sidebar-and-use-axios

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Aug 14, 2019•
edited by rullzer
Loading

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added enhancement New feature or request javascript Javascript related ticket 2. developing Work in progress high High priority labels Aug 14, 2019
@skjnldsvskjnldsv self-assigned this Aug 14, 2019
@skjnldsvskjnldsv mentioned this pull request Aug 15, 2019
Merged
25 tasks
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
Comment threadpackage.json Outdated
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
Comment threadpackage.json Outdated
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
Comment threadpackage.json Outdated
skjnldsv
skjnldsv commented Oct 6, 2019
View reviewed changes
Comment threadpackage.json
@skjnldsv
skjnldsvforce-pushed the comply-to-new-sidebar-and-use-axios branch 2 times, most recently from 58f93e8 to ed3fb3aCompareOctober 7, 2019 08:07
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 9, 2019
@skjnldsvskjnldsv mentioned this pull request Oct 29, 2019
Closed
14 tasks
ChristophWurst
ChristophWurst approved these changes Nov 19, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works (with my fixes)

@ChristophWurst
ChristophWurstforce-pushed the comply-to-new-sidebar-and-use-axios branch 3 times, most recently from cd0b14a to 5164bc0CompareNovember 19, 2019 16:00
@ChristophWurst

ChristophWurst commented Nov 19, 2019

Copy link
Copy Markdown
Member

@skjnldsv merge

ChristophWurst
ChristophWurst reviewed Nov 19, 2019
View reviewed changes
Comment threadlib/GuestManager.php Outdated
This was referenced Nov 19, 2019
Merged
Merged
@rullzer

rullzer commented Nov 27, 2019

Copy link
Copy Markdown
Member

Rebase time!

@skjnldsv

skjnldsv commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

@rullzer review time too :p

rullzer
rullzer approved these changes Nov 27, 2019
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work.
Good to go once the rebase is in for the password policy IMO

@skjnldsv
skjnldsvforce-pushed the comply-to-new-sidebar-and-use-axios branch from 5164bc0 to b4c8732CompareNovember 27, 2019 11:26
@skjnldsv
Update app to fit 18 new Sharing sidebar
a3be0db
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Use global eslint config and @nextcloud/packages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Drone fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@skjnldsv
skjnldsvforce-pushed the comply-to-new-sidebar-and-use-axios branch from b4c8732 to a3be0dbCompareNovember 27, 2019 11:27
@skjnldsv
Migrate to @nextcloud/vue
b75d6d0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

Rebased please advise

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews 2. developing Work in progress and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2019
@skjnldsv

skjnldsv commented Nov 27, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Needs nextcloud-libraries/nextcloud-vue#692nextcloud-libraries/nextcloud-vue#749

@skjnldsv
skjnldsvforce-pushed the comply-to-new-sidebar-and-use-axios branch from 534f056 to beeb82fCompareNovember 27, 2019 11:59
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 27, 2019
@skjnldsv
skjnldsvforce-pushed the comply-to-new-sidebar-and-use-axios branch from beeb82f to bd5ebe7CompareNovember 27, 2019 15:23
@skjnldsvskjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Nov 27, 2019
@skjnldsv

skjnldsv commented Nov 27, 2019

Copy link
Copy Markdown
MemberAuthor

@juliushaertl@ChristophWurst

  • Type: Exception
  • Code: 0
  • Message: Class 'OCP\Security\Events\GenerateSecurePasswordEvent' not found
  • File: /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php
  • Line: 107

Still needs a bit of love?

@rullzer

rullzer commented Nov 28, 2019

Copy link
Copy Markdown
Member

@skjnldsv did you update your server version to master?
Because it seems to work here.

@skjnldsv

skjnldsv commented Nov 28, 2019

Copy link
Copy Markdown
MemberAuthor

@rullzer ah, maybe I did not!
LGTM then :)

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 28, 2019
@skjnldsv
skjnldsv merged commit b21d65b into masterNov 28, 2019
@skjnldsv
skjnldsv deleted the comply-to-new-sidebar-and-use-axios branch November 28, 2019 08:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerrullzer approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementNew feature or requesthighHigh priorityjavascriptJavascript related ticket

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@ChristophWurst@rullzer@juliusknorr