Uh oh!
There was an error while loading. Please reload this page.
update ingress snippet comment in values.yaml - #241
Conversation
jessebot
commented
Jan 26, 2023
Could you please update the chart version and also link the most recent version of the documentation you're referencing? Other than that, it looks okay to me. Thanks for your contribution! :) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@Northcode any chance you could revisit this PR? I can confirm this fix works. |
Northcode
commented
Mar 26, 2023
@Jeroen0494 |
tvories
commented
Mar 27, 2023
I think @jessebot was requesting you remove the extra line between 34 and 35 in values.yaml |
Northcode
commented
Mar 27, 2023
@tvories |
Jeroen0494
commented
Mar 27, 2023
Uh oh!
There was an error while loading. Please reload this page.
jessebot
commented
Apr 10, 2023
Also, really quick, I'm a real person. I can't be rerun because I'm not a bot 😂 My username just has the word bot in it :) |
04b0f44 to
098f6dcCompareUpdate well-known webfinger and nodeinfo redirects to match documentation in https://docs.nextcloud.com/server/23/admin_manual/issues/general_troubleshooting.html#service-discovery Signed-off-by: Andreas Larsen <andreas@northcode.no>
Northcode
commented
Apr 11, 2023
@jessebot oh I see. In that case sorry for assuming your uhm.. type of consciousness? I guess? haha Anyways I've removed the whitespace now on both line 36 and 33 and rebased onto upstream again, incrementing the chart version to 3.5.8 |
jessebot
left a comment
There was a problem hiding this comment.
chart.yaml needs bumping. Left the suggestion so you can just click the button and we can merge this. Thank you for fixing the whitespace :)
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: JesseBot <jessebot@linux.com>
Signed-off-by: JesseBot <jessebot@linux.com>

Pull Request
Description of the change
Update well-known webfinger and nodeinfo redirects to match documentation in https://docs.nextcloud.com/server/23/admin_manual/issues/general_troubleshooting.html#service-discovery
Benefits
People just uncommenting the snippet will now have correct webfinger config, and no warnings in the nextcloud settings.
Possible drawbacks
None that I can see
Applicable issues
#240
Additional information
...
Checklist
Chart.yamlaccording to semver.