Skip to content

Add --target-branch to linting and install helm chart GHA steps, and remove deprecated input param from kind step - #387

Merged
jessebot merged 2 commits into
mainfrom
fix/add-target-branch-param-to-gha-steps
Apr 24, 2023
Merged

Add --target-branch to linting and install helm chart GHA steps, and remove deprecated input param from kind step#387
jessebot merged 2 commits into
mainfrom
fix/add-target-branch-param-to-gha-steps

Conversation

@jessebot

@jessebotjessebot commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

Pull Request

Description of the change

Updates ct commands in both the linting and installing steps to now use the param for target branch:
--target-branch ${{ github.event.repository.default_branch }}

Also removes install_local_path_provisioner param from kind action, which was causing warnings.

Benefits

now we match the example in the readme here:
https://github.com/helm/chart-testing-action

Without it, it was causing these issues:
https://github.com/nextcloud/helm/actions/runs/4787913488/jobs/8513797467

Run ct install --config ct.yaml
ct install --config ct.yaml
shell: /usr/bin/bash -e {0}
env:
CT_CONFIG_DIR: /opt/hostedtoolcache/ct/v3.8.0/x86_64/etc
VIRTUAL_ENV: /opt/hostedtoolcache/ct/v3.8.0/x86_64/venv
Installing charts...
Error: failed installing charts: failed identifying charts to process: failed running process: exit status 128
------------------------------------------------------------------------------------------------------------------------
No chart changes detected.
------------------------------------------------------------------------------------------------------------------------
failed installing charts: failed identifying charts to process: failed running process: exit status 128
Error: Process completed with exit code 1.

also prevents this warning:

Warning: Unexpected input(s) 'install_local_path_provisioner', valid inputs are ['version', 'config', 'node_image', 'cluster_name', 'wait', 'verbosity', 'kubectl_version', 'install_only']

Possible drawbacks

can't tell if we need the ct.yml anymore 🤷

Applicable issues

No issues yet 😅 Just caught this while testing something else.

Additional information

You can see the testing I did here:
https://github.com/nextcloud/helm/actions/runs/4787957878/jobs/8513900880

Checklist

Signed-off-by: JesseBot <jessebot@linux.com>
@jessebotjessebot added the CI/CD Anything to do with continuous integration or continuous deployment or release automation. label Apr 24, 2023
@jessebotjessebot self-assigned this Apr 24, 2023
variable is no longer supported
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebotjessebot changed the title Add --target-branch to linting and install helm chart GHA testing stepsAdd --target-branch to linting and install helm chart GHA steps, and remove deprecated input param from kind stepApr 24, 2023
@jessebot
jessebot requested a review from tvoriesApril 24, 2023 15:34
@jessebot
jessebot merged commit b35eaa3 into mainApr 24, 2023
@delete-merged-branch
delete-merged-branchBot deleted the fix/add-target-branch-param-to-gha-steps branch April 24, 2023 15:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CDAnything to do with continuous integration or continuous deployment or release automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jessebot@provokateurin