Uh oh!
There was an error while loading. Please reload this page.
Added support for Built-in CODE Server (ARM64) - #540
Conversation
Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
provokateurin
commented
Feb 28, 2024
Thanks for your contribution, can you link to the code that shows this is necessary? It looks like https://github.com/nextcloud/documentation/blob/e9c1af1ff00625cb24e7e6ccf4d547c15bd714c8/admin_manual/installation/nginx-root.conf.sample#L145 also doesn't have it, could you also contribute it to the general documentation? |
dgiebert
commented
Feb 28, 2024
It's a minor thing. Do you want me to bump the chart version? |
provokateurin
commented
Feb 28, 2024
Yes our CI requires every PR that touches the templates to update the version. You can just bump the patch version though since it is only a bug fix. |
dgiebert
commented
Feb 28, 2024
I will bump the version tomorrow then. Sadly I cannot find it in code right now, but there are multiple pointers (and ofc I have tested it locally) See here: CollaboraOnline/richdocumentscode#204 (comment) Might be related to the app being called different, also see here: https://github.com/CollaboraOnline/richdocumentscode?tab=readme-ov-file#implementation |
provokateurin
commented
Feb 28, 2024
I see, thanks a lot. Only bumping the version is needed, then we can merge this. |
Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
Pull Request
Description of the change
Made the nginx regex also catch the
_arm64for the code serverAdditional information
Chart.yamlaccording to semver.