Skip to content

Add a setupcheck for errors and warnings in log file - #1021

Merged
susnux merged 4 commits into
masterfrom
feat/add-setup-check-for-errors-in-log
Nov 9, 2023
Merged

Add a setupcheck for errors and warnings in log file#1021
susnux merged 4 commits into
masterfrom
feat/add-setup-check-for-errors-in-log

Conversation

@come-nc

@come-nccome-nc commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Requires nextcloud/server#32550

Adds a SetupCheck for errors in the log file in the last 7 days.

  • Add link to logreader: not supported by server yet, postponed
  • Add link to documentation: supported, but do documentation would make sense here I think, postponed

@codecov

codecovBot commented Oct 12, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (df9ce9f) 40.74% compared to head (ac41cde) 43.39%.

Additional details and impacted files
@@ Coverage Diff @@## master #1021 +/- ##
============================================
+ Coverage 40.74% 43.39% +2.65% - Complexity 159 168 +9 
============================================
Files 25 26 +1 Lines 648 689 +41 Branches 31 31 ============================================
+ Hits 264 299 +35 - Misses 384 390 +6 
FlagCoverage Δ
unit25.14% <85.36%> (+5.14%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
lib/AppInfo/Application.php20.00% <0.00%> (-2.23%)⬇️
lib/SetupChecks/LogErrors.php87.50% <87.50%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@come-nc
come-ncforce-pushed the feat/add-setup-check-for-errors-in-log branch 2 times, most recently from d074dc5 to 7f8e087CompareOctober 24, 2023 15:01
@blizzzblizzz mentioned this pull request Nov 6, 2023
@come-nc

come-nc commented Nov 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@come-nc
come-nc requested a review from susnuxNovember 7, 2023 10:54
@come-nc
come-nc marked this pull request as ready for review November 7, 2023 10:54
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the feat/add-setup-check-for-errors-in-log branch from 7f8e087 to 34cc3e1CompareNovember 7, 2023 11:29
Comment threadlib/SetupChecks/LogErrors.php Outdated
Co-authored-by: Benjamin Gaussorgues <github-fa3ie@altahrim.net>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@susnux
susnux merged commit 162c36a into masterNov 9, 2023
@susnux
susnux deleted the feat/add-setup-check-for-errors-in-log branch November 9, 2023 10:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@come-nc@susnux@Altahrim