Skip to content

dependencies: Update vite and nextcloud/vite-config - #1037

Merged
susnux merged 2 commits into
masterfrom
chore/update-vite
Nov 10, 2023
Merged

dependencies: Update vite and nextcloud/vite-config#1037
susnux merged 2 commits into
masterfrom
chore/update-vite

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Also fix the wrong css name being emitted.

@susnuxsusnux added 3. to review dependencies Pull requests that update a dependency file labels Nov 9, 2023
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@codecov

codecovBot commented Nov 9, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (923260b) 100.00% compared to head (4e8ab8c) 25.14%.

Additional details and impacted files
@@ Coverage Diff @@## master #1037 +/- ##
==============================================
- Coverage 100.00% 25.14% -74.86% - Complexity 0 168 +168 
==============================================
Files 10 16 +6 Lines 168 521 +353 Branches 31 0 -31 ==============================================
- Hits 168 131 -37 - Misses 0 390 +390 
FlagCoverage Δ
unit25.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

FilesCoverage Δ
lib/Controller/PageController.php0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnuxsusnux mentioned this pull request Nov 10, 2023
@susnuxsusnux linked an issue Nov 10, 2023 that may be closed by this pull request
@susnux
susnux merged commit 06423cc into masterNov 10, 2023
@susnux
susnux deleted the chore/update-vite branch November 10, 2023 16:16
@AndyScherzingerAndyScherzinger added this to the Nextcloud 28 milestone Nov 10, 2023
@blizzzblizzz mentioned this pull request Nov 13, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewdependenciesPull requests that update a dependency filefeedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken on Hub 7/28 Beta 2

3 participants

@susnux@Pytal@AndyScherzinger