Skip to content

fix(LogTable): implement virtual scrolling - #1505

Merged
Antreesy merged 6 commits into
masterfrom
fix/1262/virtual-scroller
Apr 22, 2025
Merged

fix(LogTable): implement virtual scrolling#1505
Antreesy merged 6 commits into
masterfrom
fix/1262/virtual-scroller

Conversation

@Antreesy

@AntreesyAntreesy commented Feb 4, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Ref #1262

Attempt to implement 'virtual scrolling':

  • copied from server/apps/settings/src/components/Users/VirtualList.vue, omitting some redundant logic for logreader

TODO:

  • expanded LogTableRow is taking more vertical space, but doesn't seem to break scroller in general, and atm collapses after leaving viewport
  • ILogEntry should contain the id, as it's not the part of the log entry from file
  • log a line for further debugging: ResizeObserver for virtual list updated', { rendered: number, total: number })

@AntreesyAntreesy added this to the Nextcloud 32 milestone Feb 4, 2025
@Antreesy
Antreesy requested a review from susnuxFebruary 4, 2025 10:31
@AntreesyAntreesy self-assigned this Feb 4, 2025
Antreesy
Antreesy commented Feb 28, 2025
View reviewed changes
Comment threadsrc/components/table/LogTable.vue Outdated
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from 99e0518 to 3b34500CompareMarch 3, 2025 23:04
@Antreesy
Antreesy requested a review from ShGKmeMarch 3, 2025 23:05
@Antreesy
Antreesy marked this pull request as ready for review March 3, 2025 23:06
@AntreesyAntreesy changed the title [WIP] fix(LogTable): implement virtual scrollingfix(LogTable): implement virtual scrollingMar 3, 2025
ShGKme

This comment was marked as resolved.

Sign in to view

@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from 3b34500 to bcde1f7CompareMarch 5, 2025 12:00
@Antreesy

This comment was marked as resolved.

Sign in to view
@Antreesy
Antreesy requested a review from PytalMarch 5, 2025 12:02
@AntreesyAntreesy mentioned this pull request Mar 6, 2025
Closed
8 tasks
TDuffinNTU
TDuffinNTU reviewed Mar 6, 2025
View reviewed changes
Comment threadsrc/components/table/LogTable.vue Outdated
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from bcde1f7 to c0a3862CompareMarch 6, 2025 17:28
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from c0a3862 to 582c0a8CompareApril 15, 2025 07:25
@Antreesy
Antreesy requested review from ShGKme and removed request for PytalApril 15, 2025 07:25
ShGKme
ShGKme approved these changes Apr 15, 2025
View reviewed changes

@ShGKmeShGKme left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but not a fan of having virtual scroll login and log table mixes in a single component.

Comment threadsrc/components/table/LogTableRow.vue Outdated
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from 582c0a8 to ba32da8CompareApril 16, 2025 15:55
@Antreesy
fix: extend ILogEntry type to include unique id
869978d
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: hide log entry second-line message unless expanded
1435fe8
- required to have all entries of same height initially
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from 69f5377 to bfc9e39CompareApril 22, 2025 07:28
@Antreesy

Antreesy commented Apr 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable31

@Antreesy

Antreesy commented Apr 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable30

@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from b453bc3 to 10140c2CompareApril 22, 2025 07:42
@Antreesy
fix: implement virtual scrolling
c815d27
- copied from server/apps/settings/src/components/Users/VirtualList.vue, omitting some redundant logic
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: adjust styles for IntersectionObserver rows
fff43cf
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: lint files
25ee6fc
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the fix/1262/virtual-scroller branch from 10140c2 to 25ee6fcCompareApril 22, 2025 07:44
@Antreesy

Antreesy commented Apr 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/compile /

@nextcloud-command
chore(assets): Recompile assets
20b3925
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Antreesy

Antreesy commented Apr 22, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Since the approve:

  • rebased
  • extended ILogEntry type with 'id' field (present since NC14 in output)
  • move ITableRow condition from template to computed
  • splitted into commits
  • smoke tested (23/400 rows)

@Antreesy
Antreesy merged commit eac6772 into masterApr 22, 2025
@Antreesy
Antreesy deleted the fix/1262/virtual-scroller branch April 22, 2025 07:52
This was referenced Apr 22, 2025
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKmeShGKmeShGKme approved these changes
@susnuxsusnuxAwaiting requested review from susnux
+1 more reviewer
@TDuffinNTUTDuffinNTUTDuffinNTU left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@AntreesyAntreesy

Labels

3. to reviewbug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@Antreesy@ShGKme@TDuffinNTU@skjnldsv@nextcloud-command