Skip to content

fix: do not poll log entries without lastReqId - #1845

Merged
Antreesy merged 4 commits into
masterfrom
fix/1271/duplicate-logs
Dec 8, 2025
Merged

fix: do not poll log entries without lastReqId#1845
Antreesy merged 4 commits into
masterfrom
fix/1271/duplicate-logs

Conversation

@Antreesy

@AntreesyAntreesy commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

Alternative (and workaround) would be to add check to the backend, like:

publicfunction poll(string$lastReqId): JSONResponse {
if ($lastReqId === '') {
returnnewJSONResponse([]);
}

But we simply should not make such request from the client

@AntreesyAntreesy added this to the Nextcloud 33 milestone Dec 8, 2025
@Antreesy
Antreesy requested a review from susnuxDecember 8, 2025 11:00
@AntreesyAntreesy self-assigned this Dec 8, 2025
@Antreesy
Antreesyforce-pushed the fix/1271/duplicate-logs branch from d7e1bc7 to 272371aCompareDecember 8, 2025 11:35
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesyforce-pushed the fix/1271/duplicate-logs branch from 272371a to 7146e64CompareDecember 8, 2025 11:39
@Antreesy

Copy link
Copy Markdown
CollaboratorAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Antreesy
Antreesy merged commit f057efc into masterDec 8, 2025
31 checks passed
@Antreesy
Antreesy deleted the fix/1271/duplicate-logs branch December 8, 2025 12:51
@Antreesy

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable32

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate log messages in browser after first js refresh

3 participants

@Antreesy@susnux@nextcloud-command