Skip to content

Add feature to view admin_audit log files - #857

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

Add feature to view admin_audit log files#857
ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost

Copy link
Copy Markdown

Add a LogFileProvider class that identifies the available log files It checks if the admin_audit app is enabled, and fetches it's logfile path.

Additionally, add ability for user to select the file they want to view. The "Download logs" button now downloads the currently selected log file.

Tested by enabling/disabling admin_audit app, toggling "Log file"

Lakshaya Tohan added 3 commits April 26, 2023 12:07
Add a LogFileProvider class that identifies the available log files
It checks if the admin_audit app is enabled, and fetches it's logfile
path.
Additionally, add ability for user to select the file they want to
view. The "Download logs" button now downloads the currently selected
log file.
Tested by enabling/disabling admin_audit app, toggling "Log file"
Signed-off-by: Lakshaya Tohan <lakshaya.tohan@gmail.com>
Signed-off-by: Lakshaya Tohan <lakshaya.tohan@gmail.com>
This fixes an error: Optional parameter $levels declared before required parameter $logfile is implicitly treated as a required parameter
Signed-off-by: Lakshaya Tohan <87015086+LakshayaTohan@users.noreply.github.com>
@joshtrichards

Copy link
Copy Markdown
Member

I haven't had an opportunity to look closely at the code yet, but I like the idea.

Some of this is based on #476, correct?

This would certainly further address #318 / #129 w/o forcing the admin to use consolidated logging (see nextcloud/documentation#10604).

P.S. Looks like one of your commits isn't signed so the tests can't run. A rebase to master probably a.good idea while you're at it. :-)

This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@ghostghost closed this by deleting the head repository Apr 20, 2026
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@joshtrichards@AndyScherzinger@blizzz@skjnldsv@szaimen