Skip to content

Execute units tests against php 8.1 & 8.2#888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nfebe wants to merge 1 commit into from
Closed

Execute units tests against php 8.1 & 8.2 #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/phpunit-mysql.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@ jobs:
strategy:
matrix:
php-versions: ['8.0', '8.1', '8.2']
server-versions: ['master']
server-versions: ['master', 'stable27']

@susnuxsusnuxJun 13, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why stable27 this is only for the master branch, stable27 should only be tested on its own branch.
(so backporting this to stable27 instead)

@nfebenfebeJun 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux the original issue : #868 requested such?

@susnuxsusnuxJun 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is about adding 8.2 also to the stable27 branch.

@nickvergessennickvergessenJun 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, what susnux says


services:
mysql:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/phpunit-oci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,8 @@ jobs:

strategy:
matrix:
php-versions: ['8.0']
server-versions: ['master']
php-versions: ['8.0', '8.1', '8.2']

@nickvergessennickvergessenJun 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also not be changed, to keep the CI matrix small.

server-versions: ['master', 'stable27']

services:
oracle:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/phpunit-pgsql.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,8 @@ jobs:

strategy:
matrix:
php-versions: ['8.0']
server-versions: ['master']
php-versions: ['8.0', '8.1', '8.2']
server-versions: ['master', 'stable27']

services:
postgres:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/phpunit-sqlite.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,8 +38,8 @@ jobs:

strategy:
matrix:
php-versions: ['8.0']
server-versions: ['master']
php-versions: ['8.0', '8.1', '8.2']
server-versions: ['master', 'stable27']

steps:
- name: Set app env
Expand Down