Skip to content

fix: Use <tfoot> for "loading older entries" row - #948

Merged
susnux merged 1 commit into
masterfrom
fix/use-tfoot-for-a11y
Jul 24, 2023
Merged

fix: Use <tfoot> for "loading older entries" row#948
susnux merged 1 commit into
masterfrom
fix/use-tfoot-for-a11y

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Follow up on #936

As discussed the "loading more entries" / "no more entries" row (the intersection observer) should be on the tfoot for accessibility.

@susnux
susnux requested a review from PytalJuly 21, 2023 23:22
@susnux
susnux marked this pull request as ready for review July 21, 2023 23:22
@codecov

codecovBot commented Jul 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +57.73% 🎉

Comparison is base (a98b582) 42.26% compared to head (2bf3443) 100.00%.

❗ Current head 2bf3443 differs from pull request most recent head a460cc5. Consider uploading reports for the commit a460cc5 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## master #948 +/- ##
==============================================
+ Coverage 42.26% 100.00% +57.73% 
==============================================
Files 23 10 -13 Lines 601 168 -433 Branches 31 31 ==============================================
- Hits 254 168 -86 + Misses 347 0 -347 
FlagCoverage Δ
unit?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux

Copy link
Copy Markdown
ContributorAuthor

/compile amend

…rver)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit 3200e6c into masterJul 24, 2023
@susnux
susnux deleted the fix/use-tfoot-for-a11y branch July 24, 2023 22:44
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@susnux@Pytal