Skip to content

Fit nextcloud css guidelines - #278

Merged
ChristophWurst merged 1 commit into
masterfrom
fix-app-navigation
Jan 13, 2017
Merged

Fit nextcloud css guidelines#278
ChristophWurst merged 1 commit into
masterfrom
fix-app-navigation

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 11, 2017

Copy link
Copy Markdown
Member

Should probably be best with the last fix from nextcloud/server#3024

@skjnldsvskjnldsv self-assigned this Jan 11, 2017
ChristophWurst
ChristophWurst reviewed Jan 12, 2017
View reviewed changes
Comment threadjs/templates/account.html
<div class="app-navigation-entry-menu">
<ul>
<li><button class="icon-rename svg" title="{{ t 'Settings' }}"></button></li>
</ul>

@ChristophWurstChristophWurstJan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@skjnldsvskjnldsvJan 12, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@ChristophWurstChristophWurstJan 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know why we had two list there

@skjnldsvskjnldsvJan 12, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@ChristophWurst

ChristophWurst commented Jan 12, 2017

Copy link
Copy Markdown
Member

bildschirmfoto von 2017-01-12 09-41-39
looks strange on FF

@skjnldsv

skjnldsv commented Jan 12, 2017

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst do you mean the scrollbar?

@ChristophWurst

ChristophWurst commented Jan 12, 2017

Copy link
Copy Markdown
Member

yes ;-)

@skjnldsv

skjnldsv commented Jan 12, 2017

Copy link
Copy Markdown
MemberAuthor

Well it isn't related to this pr ^^
And the firefox scrollbar has always been awful 😱
capture d ecran_2017-01-12_13-52-08

@ChristophWurst

ChristophWurst commented Jan 12, 2017

Copy link
Copy Markdown
Member

Well it isn't related to this pr ^^

will check again later. IIRC that little scrollbar just scrolls the three dots, not the entire list of accounts/folders.

@ChristophWurst

ChristophWurst commented Jan 12, 2017

Copy link
Copy Markdown
Member

Still the same issue when I'm on nextcloud/server#3024 and this PR's branch:
bildschirmfoto von 2017-01-12 23-02-36

@skjnldsv
Fit nextcloud css guidelines
83d078b
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Jan 13, 2017

Copy link
Copy Markdown
MemberAuthor

Fixed.

@ChristophWurst

ChristophWurst commented Jan 13, 2017

Copy link
Copy Markdown
Member

@skjnldsv which server branch did you use to test this? On master it works, but in combination with nextcloud/server#3024 I still get the scroll bar :-/

@skjnldsv

skjnldsv commented Jan 13, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@ChristophWurst the last update commit of this pr: 83d078b
with the latest nextcloud/server#3024 at nextcloud/server@ce9c833 Sorry I forgot to push 😞

ChristophWurst
ChristophWurst approved these changes Jan 13, 2017
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks good :-D

@ChristophWurst
ChristophWurst merged commit ce7f46f into masterJan 13, 2017
@ChristophWurst
ChristophWurst deleted the fix-app-navigation branch January 13, 2017 15:26
@skjnldsv

skjnldsv commented Jan 13, 2017

Copy link
Copy Markdown
MemberAuthor

😆

@lock

lockBot commented Nov 21, 2018

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and questions.

@locklockBot locked and limited conversation to collaborators Nov 21, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewdesign

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skjnldsv@ChristophWurst