Dashboard widget for NC20

[korelstar]

closes#587, see also nextcloud/server#20930

Empty content	with notes
Darkmode (outdated!)	Darkmode (outdated!)

Everything fine? @nextcloud/designers @nextcloud/notes

[claell]

One thought: Does this look coherent with the other available widgets?

[korelstar]

I'm using the Nextcloud vue components for dashboard (i.e. the DashboardWidgetItem), so I would say yes. But I don't have a complete overview over all other existing dashboard widgets, since not every app has released the dashboard yet and screenshots in respective PR's are often outdated. But that's why I'm asking for reviews, here! 😃

[jancborchardt]

Wow, awesome work @korelstar! :) Mostly small feedback inline.

Edit: If there is no note favorited (cause e.g. the person just doesn’t use the feature), I’m wondering if we should keep the space on the left open, or instead remove the indent to give more space to the notes?

[claell]

I'm using the Nextcloud vue components for dashboard (i.e. the DashboardWidgetItem), so I would say yes. But I don't have a complete overview over all other existing dashboard widgets, since not every app has released the dashboard yet and screenshots in respective PR's are often outdated. But that's why I'm asking for reviews, here! 😃

I was only looking at the screenshots in the description of nextcloud/server#20930. Those might be outdated, though.

[korelstar]

Thanks for your review, everybody!

Now, I've implemented (see updated screenshots above):

• use "New note" instead of "Create note" @jancborchardt
• use "No notes yet" instead of "No notes found" @jancborchardt
• use BeforeTemplateRenderedEvent for loading the stylesheet @nickvergessen
• show excerpt instead of category as subtext @jancborchardt
• remove space if there are no favorites @jancborchardt
• some minor optimizations

@jancborchardt If there are no favorite notes, the widget looks like this:

[jancborchardt]

Tested and works perfectly, great work @korelstar! :)

[korelstar]

@nickvergessen I think I've implemented your requests, so I'm merging this now, since I can't wait for the review anymore due to the pending release. Please give an info if there is something outstanding, I will fix this afterwards.

[nickvergessen]

Yeah sorry all fine, didn't know you are still waiting for me (also I have 200+ unread notifications atm :( )