Uh oh!
There was an error while loading. Please reload this page.
Add prioritization for Talk - #134
Merged
Merged
Conversation
mario
commented
Jun 22, 2018
ContributorAuthor
To clarify, this allows us to send high priority messages only for Talk, thus not waking up the mobile apps on more "normal" activities in return conserving battery life. |
nickvergessen
approved these changes
Jun 25, 2018
nickvergessen
left a comment
Member
There was a problem hiding this comment.
fine by me, although your PR title is lying. you are removing priority from everything else, not adding it to Talk ;)
nickvergessen
commented
Jul 11, 2018
Member
|
Signed-off-by: Mario Danic <mario@lovelyhq.com>
mario
commented
Jul 11, 2018
ContributorAuthor
Done! |
| ]; | ||
| if ($isTalkNotification) { | ||
| $priority = "high"; |
Signed-off-by: Mario Danic <mario@lovelyhq.com>
mario
commented
Jul 11, 2018
ContributorAuthor
Done! |
nickvergessen
approved these changes
Jul 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mario Danic mario@lovelyhq.com