Skip to content

[stable25] Add admin setting page with users defaults - #1369

Merged
nickvergessen merged 19 commits into
stable25from
backport/1266/stable25
Nov 16, 2022
Merged

[stable25] Add admin setting page with users defaults#1369
nickvergessen merged 19 commits into
stable25from
backport/1266/stable25

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Nov 16, 2022•
edited by nickvergessen
Loading

Copy link
Copy Markdown
  • ⚠️ This backport had conflicts and is incomplete

backport of #1266

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 25.0.2 milestone Nov 16, 2022
@github-actions

github-actionsBot commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9791 was 9500 (+3.06%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

natoponenand others added 19 commits November 16, 2022 12:03
@natoponen@nickvergessen
Add admin setting page with users defaults
2812036
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Add copyright
e3c84e8
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Apply suggestions from code review
e8ae302
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Apply suggestions from code review
9a26540
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: natoponen <57988162+natoponen@users.noreply.github.com>
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Add copyright, resolve eslint comments
a244765
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Add declare
b29a370
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@natoponen@nickvergessen
Fix identation, add appropriate not equals checks
1d2aa55
Signed-off-by: Топонен Никита <Toponen@lanit.ru>
@nickvergessen
Update lib/Listener/PostLoginListener.php
0abfc9d
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Update lib/Listener/UserCreatedListener.php
8b07a86
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Update lib/Settings/Admin.php
f211a54
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Update lib/Settings/AdminSection.php
1ab4dd2
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Update src/views/AdminSettings.vue
329c57e
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
@nickvergessen
Fix PHP CS
1d61415
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix ESLint
a7ca777
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix import path
1d9173f
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
6715e8e
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix unit tests
a2bb7d3
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix psalm
de0acdf
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
df74e38
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions

github-actionsBot commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9791 was 9500 (+3.06%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
nickvergessen merged commit 9175362 into stable25Nov 16, 2022
@nickvergessen
nickvergessen deleted the backport/1266/stable25 branch November 16, 2022 11:32
@blizzzblizzz mentioned this pull request Nov 21, 2022
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

Nextcloud 25.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen@natoponen