Uh oh!
There was an error while loading. Please reload this page.
Share notification data across tabs - #751
Merged
rullzer merged 8 commits intoSep 17, 2020
Merged
Conversation
…offline Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ChristophWurst, juliusknorr, rullzer and skjnldsvSeptember 14, 2020 14:47
rullzer
approved these changes
Sep 15, 2020
rullzer
left a comment
Member
There was a problem hiding this comment.
Whoohoo!
Tested and still works!
nickvergessen
commented
Sep 15, 2020
MemberAuthor
So aparently there are still cases where 2 tabs send the browser notification |
skjnldsv
approved these changes
Sep 16, 2020
rullzer
deleted the
techdebt/703/share-notification-data-across-tabs
branch
September 17, 2020 06:54
rullzer
commented
Sep 17, 2020
Member
Lets tackle that separatly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#703