Uh oh!
There was an error while loading. Please reload this page.
fix(routing): Extract routes even with multiple registerRoutes calls - #78
Merged
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
commented
Jan 17, 2024
MemberAuthor
CI failure is expected... |
provokateurin
commented
Jan 17, 2024
MemberAuthor
It's bad design, but not forbidden 🤷♀️ |
provokateurin
commented
Jan 17, 2024
MemberAuthor
I'll wait with merging this one until right before nextcloud/server#42888 is merged so don't constantly have red CI |
nickvergessen
commented
Jan 17, 2024
Member
But we can forbid it for OpenApi? 😅 |
provokateurin
commented
Jan 17, 2024
MemberAuthor
I don't see a problem with it tbh. With nextcloud/server#42678 this problem will be solved entirely anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happens in https://github.com/nextcloud/server/blob/master/apps/user_ldap/appinfo/routes.php, but in this particular case all the newly discovered routes have to be ignored.