Uh oh!
There was an error while loading. Please reload this page.
Revert using display name in shared albums' name - #1786
Conversation
b4827ad to
3a36fd4Compareartonge
commented
May 11, 2023
/backport to stable26 |
artonge
commented
May 11, 2023
/backport to stable25 |
This looks great! Since this PR purpose is to make it clear who shared the item with you, I would suggest showing the full name along with the avatar, using a user bubble (without the primary color), screenshots attached. What do you think? cc @szaimen :) ![]() ![]() |
szaimen
commented
May 11, 2023
Yes, using a userbubble including the display name is a good idea. The mockup looks good to me! :) |
3a36fd4 to
c6bcc03Compareartonge
commented
May 11, 2023
Thanks, screenshots updated. Good to review :) |
szaimen
left a comment
There was a problem hiding this comment.
Screenshots look good to me :)
c6bcc03 to
1c095eaCompare1c095ea to
2144dd2CompareThere was a problem hiding this comment.
Awesome, looks much better with the userbubble.
Detail: In the grid list, the "Shared by" could go on the same line as date and "X items" as that's not so long @artonge? Then there is less of a vertical change between shared and non-shared albums.
artonge
commented
May 15, 2023
I am worried that this would overflow in most cases, so keeping it as is. |
2144dd2 to
67c9374Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Right, didn’t take into account the names itself. Approving then :)
67c9374 to
5e420e9Compare+ Improve rendering of cover and header of shared albums Signed-off-by: Louis Chemineau <louis@chmn.me>
5e420e9 to
8c71a53CompareThe backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin/stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin/stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |


Revert part of #1781 to keep unique album names, and improve rendering of cover and header of shared albums
Based on concerns expressed here: #1781 (comment)