Uh oh!
There was an error while loading. Please reload this page.
LDAP backup server should not be queried when auth fails - #10031
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@## master #10031 +/- ##
=============================================
+ Coverage 31.71% 51.99% +20.27% + Complexity 26010 26007 -3
=============================================
Files 1661 1661 Lines 96137 96132 -5 Branches 1290 1290 =============================================
+ Hits 30494 49984 +19490 + Misses 65643 46148 -19495
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#9987
We should contact the backup server only when the first one is offline. This is already being dealt with the ServerNotAvailableException exception. So, if none occurs we can directly return the bind state. And therefore we don't need to take the error code into account. Added unit test to cover this scenario.