Uh oh!
There was an error while loading. Please reload this page.
[stable13] Fix filenames in sharing integration tests - #10044
Merged
MorrisJobke merged 2 commits intoJun 29, 2018
Merged
Conversation
When a file is shared and the receiver of the share already has a file with the same name that file is left untouched, and "(2)" is appended to the name of the shared file. As "textfile0.txt" is included in the user folder skeleton all the users in the integration test have that file, so when it is shared the receiver sees the share as "/textfile0 (2).txt", and her own file as "/textfile0.txt". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Add "PARENT (2)" and its subdirectories to the paths to be checked, as before only the own "PARENT" folder was being checked, but not the shared one. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Jun 29, 2018
MorrisJobke
approved these changes
Jun 29, 2018
MorrisJobke
deleted the
stable13-10040-fix-filenames-in-sharing-integration-tests
branch
June 29, 2018 07:03
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10040