Skip to content

allow admin to disable fetching of avatars as well as a specific attribute - #10098

Merged
MorrisJobke merged 2 commits into
masterfrom
feature/noid/ldap-image-attribute
Jul 11, 2018
Merged

allow admin to disable fetching of avatars as well as a specific attribute#10098
MorrisJobke merged 2 commits into
masterfrom
feature/noid/ldap-image-attribute

Conversation

@blizzz

@blizzzblizzz commented Jul 3, 2018

Copy link
Copy Markdown
Member

Allows to override the default behaviour when looking for user images in LDAP. This is controlled by the ldapUserAvatarRule configuration option, available on CLI only.

The default is (as before) to take both "jpegPhoto" and "thumbnailPhoto" into consideration:

occ ldap:set-config "s01" "ldapUserAvatarRule" "default"

Instead, a single specific attribute that carries the image data (like jpegPhoto and thumbnailPhoto do) can be set instead:

occ ldap:set-config "s01" "ldapUserAvatarRule" "data:selfiePhoto"

Or, fetching the avatar image from LDAP can be disable at all:

occ ldap:set-config "s01" "ldapUserAvatarRule" "none"

Waiting for #10083 before writing unit tests for User_LDAP and User/User.

documentation in nextcloud/documentation#803

…ibute
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the feature/noid/ldap-image-attribute branch from 97a3bd1 to 343036eCompareJuly 5, 2018 09:13
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobke

Copy link
Copy Markdown
Member

@blizzz Ready for review or still waiting?

@blizzzblizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 5, 2018
@blizzz

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke just ready 🏁

@blizzz

Copy link
Copy Markdown
MemberAuthor

Failing tests unrelated

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘
Code makes sense to me.

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 8ccb99f into masterJul 11, 2018
@MorrisJobke
MorrisJobke deleted the feature/noid/ldap-image-attribute branch July 11, 2018 10:20
MorrisJobke pushed a commit to nextcloud/documentation that referenced this pull request Jul 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@MorrisJobke@rullzer@viniciuscb