Skip to content

Correctly handle users with numeric user ids - #10161

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/10158/correctly-handle-users-with-numeric-user-ids
Jul 9, 2018
Merged

Correctly handle users with numeric user ids#10161
MorrisJobke merged 1 commit into
masterfrom
bugfix/10158/correctly-handle-users-with-numeric-user-ids

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jul 9, 2018

Copy link
Copy Markdown
Member

First user is lacking their numeric id:

Before

 - OneTwo
- admin: admin
- test1: Seattle Seahawks
- test2: New Orleans Saints
- test3: Pittsburgh Steelers
- test4: Atlanta Falcons
- test5: Jacksonville Jaguars

After

 - 123456: OneTwo
- admin: admin
- test1: Seattle Seahawks
- test2: New Orleans Saints
- test3: Pittsburgh Steelers
- test4: Atlanta Falcons
- test5: Jacksonville Jaguars

Fix#10158

@nickvergessen
Correctly handle users with numeric user ids
1ca075a
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 14 milestone Jul 9, 2018
@nickvergessennickvergessen mentioned this pull request Jul 9, 2018
Closed
MorrisJobke
MorrisJobke approved these changes Jul 9, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 9, 2018
@nickvergessen
nickvergessenforce-pushed the bugfix/10158/correctly-handle-users-with-numeric-user-ids branch from 5e402c4 to 1ca075aCompareJuly 9, 2018 13:37
@MorrisJobke
MorrisJobke merged commit 6afb8af into masterJul 9, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/10158/correctly-handle-users-with-numeric-user-ids branch July 9, 2018 13:38
@MorrisJobkeMorrisJobke mentioned this pull request Jul 10, 2018
Merged
@MorrisJobke

MorrisJobke commented Jul 11, 2018

Copy link
Copy Markdown
Member

Let me do the backport.

@MorrisJobkeMorrisJobke mentioned this pull request Jul 11, 2018
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Sep 11, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groups

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@rullzer