Skip to content

[13] prevent lock values from going negative with memcache backend - #10180

Merged
MorrisJobke merged 1 commit into
stable13from
lock-negative-13
Jul 11, 2018
Merged

[13] prevent lock values from going negative with memcache backend#10180
MorrisJobke merged 1 commit into
stable13from
lock-negative-13

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of #10116

This can be caused by the code releasing more locks then it acquires,
once the lock value becomes negative it's likely that it will never be able
to change into an exclusive lock again.
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jul 10, 2018
@icewind1991icewind1991 added this to the Nextcloud 13.0.5 milestone Jul 10, 2018
@codecov

codecovBot commented Jul 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #10180 into stable13 will decrease coverage by <.01%.
The diff coverage is 60%.

@@ Coverage Diff @@## stable13 #10180 +/- ##
==============================================
- Coverage 51.44% 51.43% -0.01% - Complexity 25141 25142 +1 
==============================================
Files 1613 1613 Lines 95647 95650 +3 Branches 1376 1376 ==============================================
Hits 49201 49201 - Misses 46446 46449 +3
Impacted FilesCoverage ΔComplexity Δ
lib/private/Lock/MemcacheLockingProvider.php92.15% <60%> (-1.6%)24 <0> (+1)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 922c2c6 into stable13Jul 11, 2018
@MorrisJobke
MorrisJobke deleted the lock-negative-13 branch July 11, 2018 07:02
@MorrisJobkeMorrisJobke mentioned this pull request Jul 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@rullzer@MorrisJobke