Uh oh!
There was an error while loading. Please reload this page.
Add options to create/remove groups via occ - #10334
Conversation
rullzer
commented
Jul 24, 2018
Nice stuff! |
rullzer
left a comment
There was a problem hiding this comment.
We require you to sign off on your commits.
git commit --amend -s
Should do the trick
Also, could you run:
bash build/autoloaderchecker.sh
To make sure the autoloader is up to date?
| @@ -0,0 +1,67 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
Could you make the file strict?
declare(strict_types=1);| return 1; | ||
| } else { | ||
| $this->groupManager->createGroup($groupName); | ||
| $group = $this->groupManager->get($groupName); |
There was a problem hiding this comment.
createGroup already returns the group no need for the get.
eb6bb4e to
2cb8f22CompareSigned-off-by: Denis Mosolov <denismosolov@gmail.com>
ChristophWurst
commented
Aug 24, 2018
(ignore the xdebug warning, this is an issue on my setup) |
ChristophWurst
commented
Aug 24, 2018
Too late to add this to NC14 IMO, so tagging this for 15. |
denismosolov
commented
Aug 24, 2018
Thanks guys! |
ChristophWurst
commented
Aug 24, 2018
#10334 (comment) -> @MorrisJobke@rullzer shall we revert this change? This is a new feature and we're past feature freeze. |
rullzer
commented
Aug 24, 2018
I'm fine with having this. Isolated new commands. |
MorrisJobke
commented
Aug 24, 2018
@denismosolov In the future please wait for the approval for merge by others if it is stated like this in the comments. We are currently shortly before the RC 1 release and want to have this stable. |
MorrisJobke
commented
Aug 24, 2018
For this one it's fine. |
denismosolov
commented
Aug 24, 2018
Sorry for the accident. I didn't know what to do after getting 2 reviews. Just clicked the merge button because UI alowed me to do that. |
Add options to create and remove groups via command line.
Requested in #8317
Syntax:
occ group:add groupidcreates a new group, groupid - the new groups nameocc group:delete groupidremoves group, cannot remove the group named 'admin'@tterranigma , @EpeR1 what do you think?
Signed-off-by: Denis Mosolov denismosolov@gmail.com