Skip to content

Structure mobile and public fixes - #10363

Merged
MorrisJobke merged 3 commits into
masterfrom
structure-mobile-and-public-fixes
Jul 24, 2018
Merged

Structure mobile and public fixes#10363
MorrisJobke merged 3 commits into
masterfrom
structure-mobile-and-public-fixes

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jul 24, 2018

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv self-assigned this Jul 24, 2018
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the structure-mobile-and-public-fixes branch from 47af43b to 84bc302CompareJuly 24, 2018 09:01
@skjnldsvskjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews high regression labels Jul 24, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone Jul 24, 2018
@skjnldsv
skjnldsv requested a review from weeman1337July 24, 2018 09:02

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzer

Copy link
Copy Markdown
Member

https://drone.nextcloud.com/nextcloud/server/9184/230 <-- is that failure related?

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobke
MorrisJobke merged commit dfe6c1b into masterJul 24, 2018
@MorrisJobke
MorrisJobke deleted the structure-mobile-and-public-fixes branch July 24, 2018 09:26
skjnldsv pushed a commit that referenced this pull request Jul 24, 2018
@danxuliu

Copy link
Copy Markdown
Member

https://drone.nextcloud.com/nextcloud/server/9184/230 <-- is that failure related?

https://drone.nextcloud.com/nextcloud/server/9180/230 <- same on master :/

Note that it is not a false positive but an actual regression introduced in 9982.

@MorrisJobke

Copy link
Copy Markdown
Member

@danxuliu I know - just want to say, that it was not a regression of this PR

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.highregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@rullzer@MorrisJobke@danxuliu