Uh oh!
There was an error while loading. Please reload this page.
Adds a setup and cli check for the recommended memory limit - #10539
Merged
Conversation
juliusknorr
requested review from
MorrisJobke, juliusknorr, nickvergessen and rullzerAugust 9, 2018 13:23
| }); | ||
| $this->registerAlias('SystemTagManager', \OCP\SystemTag\ISystemTagManager::class); | ||
| $this->registerService(MemoryInfo::class, function() { |
Member
There was a problem hiding this comment.
this should not be required but work automatically
rullzer
commented
Aug 9, 2018
Member
Lets also try to get this into 14. |
weeman1337force-pushed
the
feature-8642-memory-check
branch
2 times, most recently
from
August 9, 2018 17:56
47f9fdb to
71a3ae5Comparerullzerforce-pushed
the
feature-8642-memory-check
branch
from
August 10, 2018 11:20
71a3ae5 to
d4f26ebComparerullzer
commented
Aug 10, 2018
Member
I rebased. Squased the last commit in the first one. And bumped the autoloader. |
rullzerforce-pushed
the
feature-8642-memory-check
branch
from
August 10, 2018 11:26
d4f26eb to
6211577CompareSigned-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
…w the recommended value Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
skjnldsvforce-pushed
the
feature-8642-memory-check
branch
from
August 20, 2018 13:25
6211577 to
ce1e213Compareskjnldsv
commented
Aug 20, 2018
Member
Rebased and cleaned up. |
blizzz
reviewed
Aug 20, 2018
| @@ -0,0 +1,60 @@ | |||
| <?php | |||
Member
There was a problem hiding this comment.
declare strict types, please, and also the license header as found on other PHP files
MemberAuthor
There was a problem hiding this comment.
Thanks for the review. I added the license texts and PHP strict mode.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Aug 21, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
MemoryInfoclass that handles the memory limit query. I didn't put it into thepublicnamespace.Closes#8642