Uh oh!
There was an error while loading. Please reload this page.
only check the changed tables for oracle compliance - #10554
Closed
icewind1991 wants to merge 1 commit into
Closed
Conversation
| $this->ensureOracleIdentifierLengthLimit($targetSchema, strlen($this->connection->getPrefix())); | ||
| $comparator = new Comparator(); | ||
| $diff = $comparator->compare((new SchemaWrapper($this->connection))->getWrappedSchema(), $targetSchema); |
Member
There was a problem hiding this comment.
Instead of (new SchemaWrapper($this->connection))->getWrappedSchema() just do $this->connection->createSchema()
this prevents a migration from being blocked by tables from a disabled app Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
migration-table-check-diff
branch
from
August 6, 2018 16:03
d28005d to
0ad4750Compare| /** @var \Doctrine\DBAL\Schema\TableDiff[] $tables */ | ||
| $tables = array_merge($schema->changedTables, $schema->newTables); | ||
| foreach ($tables as $tableDiff) { | ||
| $table = $targetSchema->getTable($tableDiff->name); |
Member
There was a problem hiding this comment.
Doesn't work on mysql because the database name is added.
I will finish my manual comparing PR instead
nickvergessen
commented
Aug 6, 2018
Member
Replaced by #10555 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this prevents a migration from being blocked by tables from a disabled app
Note that this still checks all parts of the touched tables, not just the changes made to the table.