Skip to content

log entries that are hidden during file listing - #10697

Merged
MorrisJobke merged 1 commit into
masterfrom
smb-log-removed-entries
Aug 20, 2018
Merged

log entries that are hidden during file listing#10697
MorrisJobke merged 1 commit into
masterfrom
smb-log-removed-entries

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 15, 2018

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Aug 15, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Aug 15, 2018
@icewind1991icewind1991 mentioned this pull request Aug 15, 2018
Merged
blizzz
blizzz reviewed Aug 15, 2018
View reviewed changes
Comment threadapps/files_external/lib/Lib/Storage/SMB.php Outdated
}
return array_filter($files, function (IFileInfo $file) {
try {
$this->logger->debug('hiding hidden file ' . $file->getName());

@blizzzblizzzAug 15, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the state depend on the return value of the following method?

@icewind1991icewind1991Aug 15, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

🙈

@icewind1991
log entries that are hidden during file listing
bdc6d0b
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the smb-log-removed-entries branch from 6242e2f to bdc6d0bCompareAugust 15, 2018 23:20
rullzer
rullzer approved these changes Aug 16, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 🐘

@MorrisJobke
MorrisJobke merged commit 1c13e78 into masterAug 20, 2018
@MorrisJobke
MorrisJobke deleted the smb-log-removed-entries branch August 20, 2018 12:48
@rullzerrullzer mentioned this pull request Aug 22, 2018
Closed
3 tasks
@MorrisJobkeMorrisJobke mentioned this pull request Aug 24, 2018
Merged
@skjnldsv

skjnldsv commented May 13, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@icewind1991 any reason we decide not to show hidden files?
We have a fix request on this :)

@icewind1991

icewind1991 commented May 20, 2019

Copy link
Copy Markdown
MemberAuthor

because showing them would cause inconsistent views between NC and mounting the share in windows and we don't have proper hidden file handling

@skjnldsv

skjnldsv commented May 20, 2019•
edited
Loading

Copy link
Copy Markdown
Member

we don't have proper hidden file handling

What do you mean by that?

We have the show/hide hidden files option in nextcloud, so it's also inconsistent between any smb mount and what is displayed on nextcloud. 🤔
We received feedback for this issue :)

@icewind1991

icewind1991 commented May 20, 2019

Copy link
Copy Markdown
MemberAuthor

that only deals with files starting with ., there is no tracking of hiden state in the backend

@skjnldsv

skjnldsv commented May 20, 2019

Copy link
Copy Markdown
Member

Exactly, and dot files are set as hidden in samba.
So they do not appear.

@skjnldsv

skjnldsv commented May 20, 2019

Copy link
Copy Markdown
Member
smb: \> ls
. D 0 Mon May 20 23:22:09 2019
.. D 0 Mon May 20 23:21:40 2019
.test DH 0 Mon May 20 23:22:09 2019

@icewind1991

icewind1991 commented May 20, 2019

Copy link
Copy Markdown
MemberAuthor

that's samba, with windows smb servers it's different

@skjnldsv

skjnldsv commented May 20, 2019

Copy link
Copy Markdown
Member

@icewind1991 okay, though this is an issue.
How do we handle this. Do you want me to create an issue?

@icewind1991

icewind1991 commented May 20, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I can add an option to show hidden items,

please create an issue for tracking

@skjnldsvskjnldsv mentioned this pull request May 21, 2019
Closed
@skjnldsv

skjnldsv commented May 21, 2019

Copy link
Copy Markdown
Member

Awesome @icewind1991 :)
see #15644

I owe you a beer!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz left review comments
@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@skjnldsv@rullzer@MorrisJobke@blizzz