Uh oh!
There was an error while loading. Please reload this page.
fix wrong return value of filtered whats new info - #10715
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, rullzer, skjnldsv and tobiasKaminskyAugust 16, 2018 11:04
skjnldsv
approved these changes
Aug 16, 2018
blizzzforce-pushed
the
fix/noid/filterwhatsnew
branch
from
August 16, 2018 11:22
9c130f9 to
d93e0d4Compareblizzz
commented
Aug 16, 2018
MemberAuthor
Found another issue with the user facing part, were i need to force a higher z-index on the div |
rullzer
approved these changes
Aug 16, 2018
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/noid/filterwhatsnew
branch
from
August 16, 2018 11:27
d93e0d4 to
e4720b6Compareblizzz
commented
Aug 16, 2018
MemberAuthor
fine now |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current state would return null, and present nothing. Comes with unit tests.
How to test:
(to avoid cache hits, add a
false &&to the if-check in lib/private/Updater/VersionCheck.php::check() )