Uh oh!
There was an error while loading. Please reload this page.
Fixes more apps menu and settings/user menu positions - #10723
Merged
Conversation
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
blizzz
previously approved these changes
Aug 17, 2018
blizzz
left a comment
Member
There was a problem hiding this comment.
⚫🧙 ;) works and looks good. No idea whether it could have other implications, but on first sight all looks fine.
skjnldsv
requested changes
Aug 17, 2018
| position: absolute; | ||
| pointer-events: none; | ||
| right: 10px; | ||
| right: 22px; |
| nav[role='navigation'] { | ||
| display: inline-block; | ||
| width: $header-height; | ||
| width: 0; |
Member
There was a problem hiding this comment.
I'm not fond of hacks like that, I could prefer a proper :
li#more-apps {
z-index:2;
}:)
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
| } | ||
| #expanddiv:after { | ||
| right: 22px; |
Member
There was a problem hiding this comment.
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
skjnldsv
approved these changes
Aug 17, 2018
MorrisJobke
approved these changes
Aug 20, 2018
This was referenced Aug 21, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#10716
closes#10722
Tested in latest Chrome, Edge, Firefox and Safari.