Uh oh!
There was an error while loading. Please reload this page.
Only send an update sort order request if there is an user - #10738
Merged
Conversation
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
weeman1337
requested review from
LukasReschke, MorrisJobke, blizzz and danxuliuAugust 17, 2018 18:14
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
rullzer
approved these changes
Aug 17, 2018
blizzz
requested review from
ChristophWurst
and removed request for
LukasReschkeAugust 17, 2018 22:10
blizzz
commented
Aug 17, 2018
Member
Do we also have a positive test, ensuring that the request is sent when the user is logge in? |
weeman1337
commented
Aug 18, 2018
MemberAuthor
@blizzz yes, see server/apps/files/tests/js/filelistSpec.js Line 2648 in 2de34d7 |
blizzz
approved these changes
Aug 20, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#10669