Uh oh!
There was an error while loading. Please reload this page.
Adds a vendor prefix for position sticky - #10747
Merged
Merged
Conversation
kesselb
reviewed
Aug 19, 2018
| position: -webkit-sticky; // Safari support | ||
| position: sticky; | ||
| } @else { | ||
| position: sticky; |
MemberAuthor
There was a problem hiding this comment.
Argh you saw it before I could fix it ;)
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
weeman1337force-pushed
the
fix/10745/sticky-safari
branch
from
August 19, 2018 10:02
f7ed2a1 to
18b677eCompareMember
@juliushaertl do we want to introduce a mixin for two sticky only? :) |
weeman1337
commented
Aug 20, 2018
MemberAuthor
@skjnldsv the idea was to not duplicate logic. If we find out that e.g. IE freaks out with that too, it's just one place to change. |
skjnldsv
commented
Aug 20, 2018
Member
@weeman1337 Yes, I understand your logic :) |
juliusknorr
commented
Aug 20, 2018
Member
I'd say the mixin makes sense here. We need a position fixed fallback for IE when sticky is applied anyway. So better have that grouped together. |
juliusknorr
approved these changes
Aug 20, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari needs a vendor prefix for
position: sticky;.closes#10745