Skip to content

[stable13] Resolve all group memberships properly - #10783

Merged
MorrisJobke merged 1 commit into
stable13from
backport/10775/stable13
Aug 22, 2018
Merged

[stable13] Resolve all group memberships properly#10783
MorrisJobke merged 1 commit into
stable13from
backport/10775/stable13

Conversation

@blizzz

Copy link
Copy Markdown
Member

backport of #10775

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@blizzzblizzz added this to the Nextcloud 13.0.6 milestone Aug 21, 2018
@MorrisJobkeMorrisJobke changed the title Resolve all group memberships properly[stable13] Resolve all group memberships properlyAug 21, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@MorrisJobkeMorrisJobke mentioned this pull request Aug 22, 2018
8 tasks

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke
MorrisJobke merged commit 5bc7af2 into stable13Aug 22, 2018
@MorrisJobke
MorrisJobke deleted the backport/10775/stable13 branch August 22, 2018 08:51
@blizzz

Copy link
Copy Markdown
MemberAuthor

🐘

affects scnenarios only when memberUid is used to assign users to groups which is least efficient. Essentially it contains a plain uid. Values read from LDAP are not trimmed by default by us. Usually we don't read out values where they would make sense, OTOH changing behaviour isn't good for backporting. In that particular case, trimming is fine and helps fetching the DN for the given uid.

@nextcloud-botnextcloud-bot mentioned this pull request Nov 14, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke