Uh oh!
There was an error while loading. Please reload this page.
[LDAP] The WebUI Wizard also should not assign empty config IDs - #10820
Merged
Conversation
blizzzforce-pushed
the
fix/noid/emptydefaultprefix
branch
from
August 23, 2018 13:17
e166b97 to
df57e78Compareblizzz
commented
Aug 23, 2018
MemberAuthor
found another misbehaviour that should be fixed at the same place, stay tuned |
blizzzforce-pushed
the
fix/noid/emptydefaultprefix
branch
from
August 23, 2018 15:58
df57e78 to
7807addCompareblizzz
commented
Aug 23, 2018
MemberAuthor
voila |
MorrisJobke
approved these changes
Aug 24, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 689df9a the behaviour to assign only non-empty config IDs was introduced. Only, this was only effective for CLI and OCS API.
Related to #3270.
The web UI creates now also a full configuration on first load. This fixes#5094.